Enable building with GCC 14 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I tried to build the package with GCC 14, I got the following
error:
src/ThirdParty/Minizip/minizip/miniunz.c:141:11: error:
implicit declaration of function ‘mkdir’; did you mean ‘mymkdir’?
[-Wimplicit-function-declaration]
It turns out that GCC now conforms more strictly to the C standard, and
some issues that were previously only warned about are now treated as
errors. `implicit-function-declaration` is one of these. For more
info, see:
https://gcc.gnu.org/gcc-14/porting_to.html#implicit-function-declaration
The solution is to patch the Minizip code so that the appropriate header
for `mkdir()`, which is `<sys/stat.h>`, gets included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to build the package with GCC 14, I got the following error:
It turns out that GCC now conforms more strictly to the C standard, and some issues that were previously only warned about are now treated as errors.
implicit-function-declarationis one of these. For more info, see: https://gcc.gnu.org/gcc-14/porting_to.html#implicit-function-declarationThe solution is to patch the Minizip code so that the appropriate header for
mkdir(), which is<sys/stat.h>, gets included.